Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package versions #405

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

jasonmreding
Copy link
Collaborator

Description

Increment package versions to indicate new features.

Implementation

Updated to new minor version to indicate presence of new features. Updated minimum package version since we are using new APIs that are only present in the latest package.

Testing

N/A

…cies to indicate requirement on new features.
@dixonjoel
Copy link
Collaborator

Copy link
Collaborator

@dixonjoel dixonjoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a query about another .vipb.

@jasonmreding
Copy link
Collaborator Author

Do we not want to bump https://github.com/ni/grpc-labview/blob/master/labview%20source/gRPC%20lv%20Servicer/build%20spec/LabVIEW%20gRPC%20Servicer.vipb as well?

There is nothing in that package that changed which is why I didn't change it. This would be my preference over say always bumping all three packages to have the same version number even if nothing changed in some of the packages.

@jasonmreding jasonmreding reopened this Feb 3, 2025
@jasonmreding jasonmreding merged commit 98d66b5 into master Feb 3, 2025
9 checks passed
@dixonjoel
Copy link
Collaborator

Do we not want to bump https://github.com/ni/grpc-labview/blob/master/labview%20source/gRPC%20lv%20Servicer/build%20spec/LabVIEW%20gRPC%20Servicer.vipb as well?

There is nothing in that package that changed which is why I didn't change it. This would be my preference over say always bumping all three packages to have the same version number even if nothing changed in some of the packages.

Maybe. But then when it comes to making a release, you'd release packages with different versions? That seems confusing to me. Anyway, we can defer this decision to a release.

@dixonjoel dixonjoel deleted the users/jreding/UpdatePackageVersions branch February 4, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants